Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Refactor postNotifications matcher using Predicate.init #581

Merged
merged 1 commit into from
Jul 28, 2018
Merged

[7.x] Refactor postNotifications matcher using Predicate.init #581

merged 1 commit into from
Jul 28, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Jul 20, 2018

Replacing Predicate.fromDeprecatedClosure.

@ikesyo
Refactor postNotifications matcher using Predicate.init
32390fd 
Replacing `Predicate.fromDeprecatedClosure`.
@ikesyo ikesyo requested a review from a team July 20, 2018 10:01
sharplet
sharplet approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shiny

@ikesyo ikesyo merged commit 51afbff into 7.x-branch Jul 28, 2018
@ikesyo ikesyo deleted the refactor-postnotifications-matcher branch July 28, 2018 00:16
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
@ikesyo
Merge pull request Quick#581 from Quick/refactor-postnotifications-ma…
213bcd7 
…tcher

[7.x] Refactor `postNotifications` matcher using `Predicate.init`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharplet sharplet sharplet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikesyo @sharplet